RFR: 8324649: Shenandoah: replace implementation of free set [v57]

Kelvin Nilsen kdnilsen at openjdk.org
Fri May 10 18:04:23 UTC 2024


On Fri, 10 May 2024 17:57:22 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Thanks for review.  I'll work through these suggestions.  Question about copyright: I guess this is pretty much "all new", but the code was derived from original code, and much of the public API was borrowed from original.  So I think maybe I should keep Red Hat copyright, and add Amazon copyright.  What do you advise?
>
> But has it been derived from Red Hat code? My understanding was that it's basically a fork of src/hotspot/share/utilities/bitMap.* ? Which is Oracle-copyrighted. Is that correct?

Sorry.  I didn't look closely.  This was not derived from original code.  I wrote this blind to the original, and then I made changes under guidance of reviewers to harmonize the API with Oracle implementation of bitMap.  So I think your original comment about copyright is appropriate.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1597059209


More information about the shenandoah-dev mailing list