RFR: 8324649: Shenandoah: replace implementation of free set [v4]

[Y. Srinivas Ramakrishna]

On Tue, 14 May 2024 01:39:57 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Added similar documentation here.  Thanks.
>
> @kdnilsen ... bumping this up. I see that the documentation was added for precondition, but not the check/assert itself here in the implementation. Commenting to unresolve previously resolved comment.

... unless this gets checked somewhere more appropriate in the callee chain. When documented as a precondition, it's often easiest to catch debug if asserted upstream rather than deep downstream where context may be difficult to work backwards to.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1599274274