RFR: 8332042: Move MEMFLAGS to its own include file [v2]
Thomas Stuefe
stuefe at openjdk.org
Tue May 14 07:01:03 UTC 2024
On Mon, 13 May 2024 14:47:18 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> I don't feel like starting that particular bike shedding discussion :) But sure, sometime in the future we should do this. Here, I want it to be a simple renaming change.
>
> Right. That's why I prefixed this with "Open-ended comment/question", trying to make it super clear that it wasn't intended as a request for this PR, but rather a way to at least plant the seed of an idea that we might want to fix this eyesore.
I agree with you on the eyesore.
MEMFLAGS does not follow any established convention, the implied plural is strange (its just one flag, not a set of), etc. We will change it sometime in the future.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19172#discussion_r1599478327
More information about the shenandoah-dev
mailing list