RFR: 8324649: Shenandoah: replace implementation of free set [v59]

[Kelvin Nilsen]

On Tue, 14 May 2024 01:08:19 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix copyright notice on test file
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 103:
> 
>> 101: 
>> 102:   // Set the partition id for a particular region without adjusting interval bounds or usage/capacity tallies
>> 103:   inline void raw_set_membership(size_t idx, ShenandoahFreeSetPartitionId p) {
> 
> I realize that the word `set` can be a little ambiguous here (from the mathematical notion of a set as  a collection of things), although the fact that it has a void return type tells us that `set` is the imperative verb here, not a collection of things. May be `raw_assign_membership(size_t region_idx, ShFSPId p)` if you want to, but I may be splitting hairs here :-)

Thanks.  Making this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1601756334