RFR: 8324649: Shenandoah: replace implementation of free set [v59]

[Kelvin Nilsen]

On Tue, 14 May 2024 01:17:03 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix copyright notice on test file
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 109:
> 
>> 107:   // Set the Mutator intervals, usage, and capacity according to arguments.  Reset the Collector intervals, used, capacity
>> 108:   // to represent empty Collector free set.
>> 109:   void establish_intervals(ssize_t mutator_leftmost, ssize_t mutator_rightmost,
> 
> Why not clarify in name via `establish_mutator_intervals` ? (I noted there isn't a corresponding method for "collector intervals", although there are corresponding fields for its left and rightmosts etc.) A documentation comment somewhere indicating how/when those get established would be useful. I see them being incrementally updated in the incremental manipulation of set memberships, but wanted to get a sense of the reasons for this asymmetry (and for that reason to be documented when we revisit this code many moons in the future).

Thanks.  Making this change and adding a comment to motivate this "special" method for mutator intervals.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1601764093