RFR: 8332548: GenShen: Factor generational mode out of gc helpers
William Kemper
wkemper at openjdk.org
Tue May 21 21:29:21 UTC 2024
On Tue, 21 May 2024 17:00:30 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> Some of the generational mode support in `shenandoahConcurrentGC.cpp` and `shenandoahDegeneratedGC.cpp` can be factored into generational mode specific files and coalesced under fewer generational mode checks.
>
> src/hotspot/share/gc/shenandoah/shenandoahGenerationalHeap.hpp line 111:
>
>> 109: TransferResult balance_generations();
>> 110:
>> 111: // Balance generations, coalesce and fill old regions if necessary
>
> To keep with surrounding documentation style, use the form "Balances generations, coalesces and fills ... etc."
>
> The same comment might apply at line 53 further up too, but doesn't matter since there are no other comments nearby wrt which it would look inconsistent (in either the prescriptive or descriptive style).
Done.
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/436#discussion_r1608971843
More information about the shenandoah-dev
mailing list