RFR: 8332548: GenShen: Factor generational mode out of gc helpers [v2]

Y. Srinivas Ramakrishna ysr at openjdk.org
Tue May 21 22:18:23 UTC 2024


On Tue, 21 May 2024 21:11:37 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Or may be just an issue with how this displays in the diffs. Worth a quick check.
>
> Good eye. I pulled this into the preceding `else` block because `merge_write_table` really means `merge_write_card_table`. It's only for the generational mode, so we don't need to execute it in non-generational modes as was done before this change.

ah, ok. I see that now. The diff had looked weird to me. Looks good with yr help above :-)

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/436#discussion_r1609008154


More information about the shenandoah-dev mailing list