RFR: 8331539: [REDO] NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v2]

Afshin Zafari azafari at openjdk.org
Fri May 24 08:54:08 UTC 2024


On Thu, 23 May 2024 12:38:40 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed the missing parts of shenandoahHeap.cpp
>
> src/hotspot/os/posix/os_posix.cpp line 386:
> 
>> 384:   if (begin_offset > 0) {
>> 385:     if (os::release_memory(extra_base, begin_offset))
>> 386:     {
> 
> The `{` should be moved to the line above.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19343#discussion_r1613115512


More information about the shenandoah-dev mailing list