RFR: 8331539: [REDO] NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v2]

[Afshin Zafari]

On Thu, 23 May 2024 11:57:17 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed the missing parts of shenandoahHeap.cpp
>
> src/hotspot/share/cds/metaspaceShared.cpp line 1088:
> 
>> 1086: #endif // ASSERT
>> 1087: 
>> 1088:     if (archive_space_rs.is_reserved()) {
> 
> We've already asserted that this should be true, so this if should not be needed.

I had to add these, since the `log_info(cds)` calls caused the assertions in the `ReservedSpace` getters raised (IIRC, even during jdk-build).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19343#discussion_r1613148798