RFR: 8331539: [REDO] NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v2]

[Afshin Zafari]

On Thu, 23 May 2024 12:10:17 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed the missing parts of shenandoahHeap.cpp
>
> src/hotspot/share/cds/metaspaceShared.cpp line 1341:
> 
>> 1339:   } else {
>> 1340:     if (use_archive_base_addr && base_address != nullptr) {
>> 1341:       total_space_rs = ReservedSpace(total_range_size, archive_space_alignment,
> 
> Can you explain why you changed this?
> 
> It's also interesting that after this change we only use `base_address_alignment` in asserts. I think this indicates that something should be cleaned up / fixed here.

That comes after merge with mainline.
I trusted the tests in tiers 1-5 for the correctness of this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19343#discussion_r1613163280