RFR: 8331539: [REDO] NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v2]

[Afshin Zafari]

On Thu, 23 May 2024 12:44:42 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed the missing parts of shenandoahHeap.cpp
>
> src/hotspot/share/memory/virtualspace.hpp line 63:
> 
>> 61:   //                       it should not change after.
>> 62:   //  * _alignment       - Not to be changed after initialization
>> 63:   //  * _executable      - Not to be changed after initialization
> 
> I think this would be a good change to do in the future, but currently this isn't true. `clear_members` do clear these fields, so I think you should remove these two lines.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19343#discussion_r1613175723