RFR: 8331539: [REDO] NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v2]

[Afshin Zafari]

On Thu, 23 May 2024 11:58:15 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed the missing parts of shenandoahHeap.cpp
>
> src/hotspot/share/cds/metaspaceShared.cpp line 1092:
> 
>> 1090:                     p2i(archive_space_rs.base()), p2i(archive_space_rs.end()), archive_space_rs.size());
>> 1091:     }
>> 1092:     if (class_space_rs.is_reserved()) {
> 
> `class_space_rs.is_reserved()` is asserted if `if (Metaspace::using_class_space())` is taken. I think this could be changed to:
> Suggestion:
> 
>     if (Metaspace::using_class_space()) {

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19343#discussion_r1613208902