RFR: 8331539: [REDO] NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v2]

Afshin Zafari azafari at openjdk.org
Fri May 24 13:46:15 UTC 2024


On Fri, 24 May 2024 09:33:06 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed the missing parts of shenandoahHeap.cpp
>
> src/hotspot/share/cds/metaspaceShared.cpp line 1169:
> 
>> 1167:           // Set up compressed Klass pointer encoding: the encoding range must
>> 1168:           //  cover both archive and class space.
>> 1169:           assert(class_space_rs.is_reserved(), "Memory region should be reserved.");
> 
> Not necessary. Checked in reserve_address_space_for_archives, and in Metaspace::initialize_class_space

Removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19343#discussion_r1613503505


More information about the shenandoah-dev mailing list