RFR: 8331539: [REDO] NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v2]
Afshin Zafari
azafari at openjdk.org
Fri May 24 13:46:15 UTC 2024
On Fri, 24 May 2024 09:41:25 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> That comes after merge with mainline.
>> I trusted the tests in tiers 1-5 for the correctness of this change.
>
> No, I think this is wrong. I changed it with https://github.com/openjdk/jdk/pull/19152.
>
> Please be careful, this part is rather tricky, and a lot of thought went into this. And I am pretty sure we don't cover all possible code paths in tests.
>
> Please also note that I am working on adding no-access zones for the Klass Encoding range (see https://github.com/openjdk/jdk/pull/19290), which may impact these regions too.
Overlooked in merge.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19343#discussion_r1613504094
More information about the shenandoah-dev
mailing list