RFR: 8328944: NMT reports "unknown" memory

David Holmes dholmes at openjdk.org
Mon Nov 4 01:27:38 UTC 2024


On Fri, 1 Nov 2024 20:44:50 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> We use mtNone value in several functions default parameters, which may show up in NMT reports.
> 
> We address this, by removing the default value and forcing, where possible, for the callers to declare NMT tag that reflects the usage.
> 
> Eventually the goal would be not to use mtNone anywhere, but we are not there quite yet.
> 
> TODO: update copyrights.
> 
> Testing: undergoing MARCH5 tier1-5 ...

Seems okay in principle, but you will need someone familiar with each modified area to confirm that the chosen tags are appropriate - I'm unsure about the use of `mtClass` versus `mtClassShared` for example.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21843#pullrequestreview-2412003334


More information about the shenandoah-dev mailing list