RFR: 8344260: GenShen: Excess unaffiliated regions reserved for old will not be transferred to young

[Y. Srinivas Ramakrishna]

On Fri, 15 Nov 2024 00:41:52 GMT, William Kemper <wkemper at openjdk.org> wrote:

> Accidental assignment to new (and unread) variable.

Marked as reviewed by ysr (Committer).

src/hotspot/share/gc/shenandoah/shenandoahGeneration.cpp line 455:

> 453:     // excess_old < unaffiliated old: we can give back MIN(excess_old/region_size_bytes, unaffiliated_old_regions)
> 454:     size_t excess_regions = excess_old / region_size_bytes;
> 455:     regions_to_xfer = MIN2(excess_regions, unaffiliated_old_regions);

Yikes! Thanks for finding this!

Did it make any difference to performance? Say with SPECjbb, e.g.?

-------------

PR Review: https://git.openjdk.org/shenandoah/pull/538#pullrequestreview-2437527622
PR Review Comment: https://git.openjdk.org/shenandoah/pull/538#discussion_r1843100551