RFR: 8344263: GenShen: Reduce extraneous log messages at INFO level [v4]

William Kemper wkemper at openjdk.org
Fri Nov 15 21:08:12 UTC 2024


On Fri, 15 Nov 2024 03:50:02 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix formatting for non-generational log messages
>
> Can you share an example snippet (in the ticket or in the PR) of what we would see with a young and an old cycle with the reduced info-level logging?
> 
> The changes to convert from info to debug all look good to me.

@ysramakrishna - I've changed the generation names to also be proper case for consistency with other usages. On second thought, I don't think we need the generation name in the trigger messages. It's pretty clear from context what's being collected (non-generational mode):

[2.644s][info][gc] Trigger: Average GC time (52.87 ms) is above the time for average allocation rate (20071 KB/s) to deplete free headroom (0B) (margin of error = 3.27)
[2.644s][info][gc] GC(40) Concurrent reset (unload classes) 0.077ms
[2.645s][info][gc] GC(40) Pause Init Mark (unload classes) 0.057ms

(generational mode):

[3.176s][info][gc] Trigger: Average GC time (14.74 ms) is above the time for average allocation rate (51928 KB/s) to deplete free headroom (542K) (margin of error = 2.01)
[3.176s][info][gc] GC(28) Concurrent reset (Young) 0.075ms
[3.176s][info][gc] GC(28) Pause Init Mark (Young) 0.074ms

-------------

PR Comment: https://git.openjdk.org/shenandoah/pull/540#issuecomment-2479922303


More information about the shenandoah-dev mailing list