RFR: 8344263: GenShen: Reduce extraneous log messages at INFO level [v4]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Mon Nov 18 18:29:17 UTC 2024
On Fri, 15 Nov 2024 21:04:00 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Genshen logs a lot of fine level detail at `gc=info`. This category should be reserved for major phase changes in the gc cycle.
>
> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix formatting for non-generational log messages
One question re:
> [3.055s][info][gc] Trigger: Average GC time (22.07 ms) is above the time for average allocation rate (53621 KB/s) to deplete free headroom (0B) (margin of error = 1.91)
[3.055s][info][gc] GC(29) Concurrent reset (Young) 0.042ms
[3.055s][info][gc] GC(29) Pause Init Mark (Young) 0.037ms
[3.055s][info][gc] GC(29) Concurrent remembered set scanning 0.064ms
[3.056s][info][gc] GC(29) Concurrent marking roots 0.278ms
[3.057s][info][gc] GC(29) Concurrent marking (Young) 1.779ms
[3.058s][info][gc] GC(29) Pause Final Mark (Young) 0.116ms
[3.058s][info][gc] GC(29) Concurrent weak references (Young) 0.017ms
[3.058s][info][gc] GC(29) Concurrent weak roots (Young) 0.116ms
[3.058s][info][gc] GC(29) Concurrent cleanup (Young) 30M->30M(32M) 0.003ms
Is there a reason not to use "(Young)" against the remainder of the phases as well for clarity, when appropriate? Also wondering if the same would be true of the Trigger.
I imagine there are Triggers for Old. How are they logged?
-------------
PR Comment: https://git.openjdk.org/shenandoah/pull/540#issuecomment-2483807263
More information about the shenandoah-dev
mailing list