RFR: 8344321: GenShen: Fix various sonar scan warnings

[Kelvin Nilsen]

On Tue, 19 Nov 2024 18:19:47 GMT, William Kemper <wkemper at openjdk.org> wrote:

> Various sonar warnings are fixed: 
> * unused variables removed
> * implicit casts made explicit
> * members are all initialized

Thanks.  Looks good.

-------------

Marked as reviewed by kdnilsen (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/544#pullrequestreview-2446276313