RFR: 8342444: Shenandoah: Uncommit regions from a separate, STS aware thread [v6]

Aleksey Shipilev shade at openjdk.org
Wed Nov 20 09:33:17 UTC 2024


On Wed, 20 Nov 2024 01:44:28 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Currently, Shenandoah uncommits regions from its control thread. The control thread is responsible for starting GC cycles in a timely fashion. Uncommitting memory from this thread may introduce unwanted delays in the control thread's response to GC pressure.
>
> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Allow commits initially

Almost there, modulo restoring the logging.

src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp line 267:

> 265:       last_sleep_adjust_time = current;
> 266:     }
> 267: 

Nit: No need for this newline, the sleep logically relates to this block.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22019#pullrequestreview-2448019848
PR Review Comment: https://git.openjdk.org/jdk/pull/22019#discussion_r1849943600


More information about the shenandoah-dev mailing list