RFR: 8344638: GenShen: Verifier should not touch claim token

Aleksey Shipilev shade at openjdk.org
Wed Nov 20 19:29:33 UTC 2024


On Wed, 20 Nov 2024 19:17:54 GMT, William Kemper <wkemper at openjdk.org> wrote:

> GenShen is using parallel_threads_do for a verification step, but this uses a 'claim token' which is shared by normal gc activity. The verifier should not touch this shared state, lest it interfere with (or be interfered with by) the gc cycle.
> 
> # Testing
> 
> Ran this through internal pipelines: Dacapo, Extremem, SpecJBB2015, SpecJVM2008, Heapothesys (with and without GC stress flags).

Yup, this is a right thing to do.

-------------

Marked as reviewed by shade (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/546#pullrequestreview-2449517446


More information about the shenandoah-dev mailing list