RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v8]
William Kemper
wkemper at openjdk.org
Thu Nov 21 18:15:42 UTC 2024
On Thu, 21 Nov 2024 10:16:16 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> William Kemper has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 524 commits:
>>
>> - Merge remote-tracking branch 'shenandoah/master' into great-genshen-pr-redux
>> - 8344670: GenShen: Use concurrent worker session for concurrent mark phase
>>
>> Reviewed-by: kdnilsen
>> - 8344640: GenShen: Reuse existing card mark barrier function when dropping references
>>
>> Reviewed-by: shade, ysr
>> - 8344592: GenShen: Remove unnecessary comments and changes
>>
>> Reviewed-by: kdnilsen
>> - 8344263: GenShen: Reduce extraneous log messages at INFO level
>>
>> Reviewed-by: ysr, shade
>> - 8344638: GenShen: Verifier should not touch claim token
>>
>> Reviewed-by: shade
>> - Merge
>> - 8344320: GenShen: Possible null pointer usage in shGenerationalHeap
>>
>> Reviewed-by: wkemper, ysr
>> - 8344321: GenShen: Fix various sonar scan warnings
>>
>> Reviewed-by: kdnilsen, shade
>> - 8344264: GenShen: Improve comments and method names
>>
>> Reviewed-by: shade
>> - ... and 514 more: https://git.openjdk.org/jdk/compare/95a00f8a...7ab16403
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp line 514:
>
>> 512:
>> 513: public:
>> 514: ShenandoahController* control_thread() { return _control_thread; }
>
> This method and field is probably `controller` then, right?
Left the accessor and field with the same name to reduce churn. Clients of this method don't really need to change because in most (all?) cases, the public API of `ShenandoahControlThread` is declared in `ShenandoahController`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21273#discussion_r1852636871
More information about the shenandoah-dev
mailing list