RFR: 8344797: GenShen: Update and rename confusing method

William Kemper wkemper at openjdk.org
Fri Nov 22 17:22:42 UTC 2024


On Fri, 22 Nov 2024 00:43:31 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp line 274:
>> 
>>> 272:   if (_cancel_requested_time > 0) {
>>> 273:     double cancel_time = os::elapsedTime() - _cancel_requested_time;
>>> 274:     log_debug(gc)("GC cancellation took %.3fs", cancel_time);
>> 
>> may not be significant, but would prefer to avoid os::elapsedTime() invocation if we're not logging debug.
>
> maybe write the argument to log_debug() as os::elapsedTime() - _cancel_requested_time.

That's a good catch and an easy change.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/550#discussion_r1854336421


More information about the shenandoah-dev mailing list