RFR: 8334147: Shenandoah: Avoid taking lock for disabled free set logging [v3]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Fri Oct 4 18:14:00 UTC 2024
On Wed, 2 Oct 2024 21:32:28 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Not clean. Backport to only take lock for logging when log level is enabled.
>
> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix old gen usage of shFreeSet::log_status
Backport LGTM.
To Kelvin's question: I think we don't need the lock as these fields are updated only by the control thread (for consumption by jmx metrics and such). (I could be wrong and didn't check super-carefully.)
-------------
Marked as reviewed by ysr (Committer).
PR Review: https://git.openjdk.org/shenandoah-jdk21u/pull/113#pullrequestreview-2348821403
More information about the shenandoah-dev
mailing list