RFR: 8342001: GenShen: Factor cases for allocation type into separate methods

[Y. Srinivas Ramakrishna]

On Fri, 11 Oct 2024 23:32:35 GMT, William Kemper <wkemper at openjdk.org> wrote:

> Prune switch statement which has grown unwieldy.

src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 331:

> 329:   void flip_to_old_gc(ShenandoahHeapRegion* r);
> 330: 
> 331:   // Handle allocation from mutator

"from" -> "by" (or may be even "for" as in the name of the method).

src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 340:

> 338:   HeapWord* allocate_for_collector(ShenandoahAllocRequest& req, bool& in_new_region);
> 339:   bool can_allocate_in_new_region(const ShenandoahAllocRequest& req);
> 340:   HeapWord* try_allocate_from_mutator(ShenandoahAllocRequest& req, bool& in_new_region);

May be a 1-line spec comment for each of these methods?

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/511#discussion_r1797524028
PR Review Comment: https://git.openjdk.org/shenandoah/pull/511#discussion_r1797523479