RFR: 8342001: GenShen: Factor cases for allocation type into separate methods [v2]

Y. Srinivas Ramakrishna ysr at openjdk.org
Tue Oct 15 18:00:42 UTC 2024


On Mon, 14 Oct 2024 22:09:25 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> I also wonder if `allocate_from_left` etc., since they seem to involve only mutator allocations, should include `mutator` somewhere in the name of the method; if so, I wonder about why we maintain the bias variable for the other partitions? (I suppose we don't but since each is a partition and the variable is associated with each partition, it's there. If we don't think we'll need  bias for other allocations, it might make sense to move it to the free set, but I'd hold off on that until it's clear that directional bias for allocation isn't going to be useful for collector allocations.
>
> We do also use the allocation bias for collector allocations. I have a deeper refactoring related to this allocation bias here: https://github.com/openjdk/shenandoah/pull/512, but I've left it in draft status pending pipeline test results.

ok. Yes, not immediately necessary. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/511#discussion_r1801673018


More information about the shenandoah-dev mailing list