RFR: 8342079: Shenandoah: Remove extra ShenandoahInitMarkRootsClosure
Roman Kennke
rkennke at openjdk.org
Thu Oct 17 14:56:13 UTC 2024
On Mon, 14 Oct 2024 18:42:53 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> `ShenandoahInitMarkRootsClosure` in `ShenandoahSTWMark` is semantically similar to the shared `ShenandoahMarkRefsClosure`. It misses subclassing the metadata-visiting superclass, though, and `ShenandoahMarkRefsClosure` does it right. It is cleaner and safer to use the super-class directly, as concurrent mark does it.
>
> Additional testing:
> - [x] Linux x86_64 server fastdebug, `hotspot_gc_shenandoah`
Yes, that makes sense. The extra metadata stuff would not be used during init-mark, anyway.
-------------
Marked as reviewed by rkennke (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21504#pullrequestreview-2375499969
More information about the shenandoah-dev
mailing list