RFR: 8338737: Shenandoah: Reset marking bitmaps after the cycle [v4]

Xiaolong Peng xpeng at openjdk.org
Fri Oct 18 16:29:48 UTC 2024


> All the shenandoah passed, still waiting for our test farm to verify performance.
> 
> Reset marking bitmaps after collection cycle, for GenShen only do this for young generation, also choose not do this for Degen and full GC since both are running at safepoint, we should leave safepoint as ASAP.
> 
> I have run same workload for 30s with shenandoah in generational mode and classic mode, average average time of concurrent reset dropped significantly(283us to 109us for GenShen, 276us to 167us for classic shenandoah. 
> 
> Classic shenandoah baseline:
> 
> [30.973s][info][gc,stats    ] Concurrent Reset               =    0.148 s (a =      276 us) (n =   536) (lvls, us =      141,      205,      240,      291,      694)
> [30.973s][info][gc,stats    ] Pause Init Mark (G)            =    0.136 s (a =      253 us) (n =   536) (lvls, us =      119,      242,      254,      264,      926)
> [30.973s][info][gc,stats    ] Pause Init Mark (N)            =    0.047 s (a =       87 us) (n =   536) (lvls, us =       62,       84,       88,       91,      110)
> ...
> 
> 
> Classic shenandoah reset bitmaps after cycle:
> 
> [30.967s][info][gc,stats    ] Concurrent Reset               =    0.109 s (a =      167 us) (n =   652) (lvls, us =       48,      113,      139,      160,      888)
> [30.967s][info][gc,stats    ] Concurrent Reset After Collect =    0.085 s (a =      132 us) (n =   648) (lvls, us =      107,      121,      125,      131,      532)
> [30.967s][info][gc,stats    ] Pause Init Mark (G)            =    0.189 s (a =      289 us) (n =   652) (lvls, us =      117,      260,      277,      291,     2297)
> [30.967s][info][gc,stats    ] Pause Init Mark (N)            =    0.058 s (a =       89 us) (n =   652) (lvls, us =       62,       85,       89,       94,      143)
> ...
> 
> 
> GenShen baseline
> 
> [31.008s][info][gc,stats    ] Concurrent Reset               =    0.107 s (a =      283 us) (n =   379) (lvls, us =      143,      225,      283,      330,      753)
> [31.008s][info][gc,stats    ] Pause Init Mark (G)            =    0.098 s (a =      259 us) (n =   379) (lvls, us =      104,      227,      262,      305,     1033)
> [31.008s][info][gc,stats    ] Pause Init Mark (N)            =    0.034 s (a =       90 us) (n =   379) (lvls, us =       67,       81,       89,       99,      130)
> ...
> 
> 
> GenShen reset bitmaps after cycle
> 
> 
> [30.977s][info][gc,stats    ] Concurrent Reset               =    0.050 s (a =      109 us) (n =   462) (lvls, us =       54,       77,      100,      125,      496)
> [30.977s][...

Xiaolong Peng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 27 additional commits since the last revision:

 - Merge branch 'openjdk:master' into genshen-JDK-8338737
 - set need_bitmap_reset flag when change affiliation of heap region from OLD_GENERATION
 - Address review comments
 - Reset bitmap after ShenandoahOldGC
 - Not rest bitmap after cycle if it needs to bootstrap old gc
 - typo in comments
 - Minimize the regions to walk when reset bitmap
 - comments
 - bug fix
 - Fix most of test failures
 - ... and 17 more: https://git.openjdk.org/shenandoah/compare/f5e8affa...d2835924

-------------

Changes:
  - all: https://git.openjdk.org/shenandoah/pull/516/files
  - new: https://git.openjdk.org/shenandoah/pull/516/files/d4fddac5..d2835924

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=shenandoah&pr=516&range=03
 - incr: https://webrevs.openjdk.org/?repo=shenandoah&pr=516&range=02-03

  Stats: 221 lines in 6 files changed: 89 ins; 69 del; 63 mod
  Patch: https://git.openjdk.org/shenandoah/pull/516.diff
  Fetch: git fetch https://git.openjdk.org/shenandoah.git pull/516/head:pull/516

PR: https://git.openjdk.org/shenandoah/pull/516


More information about the shenandoah-dev mailing list