RFR: 8342560: GenShen: Fix confusing method name [v3]

[William Kemper]

On Fri, 18 Oct 2024 16:55:44 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Rename `is_old` to make it more clear that this about pointers that are outside the scope of a young collection.
>
> William Kemper has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'shenandoah/master' into fix-confusing-method
>  - Use an even better name, add an explanatory comment
>  - 8342564: GenShen: Only reference young/old generation names in generational mode
>    
>    Reviewed-by: xpeng, ysr
>  - 8342214: GenShen: Reduce code duplication in shFreeSet with iterator abstraction
>    
>    Reviewed-by: kdnilsen, ysr
>  - 8342239: GenShen: Revert changes in adaptive heuristic to avoid overflow on 32 bit
>    
>    Reviewed-by: ysr
>  - 8342278: GenShen: Move non-generational mode test out of generational test configuration
>    
>    Reviewed-by: ysr
>  - 8342255: GenShen: Remove unnecessary enum initial values
>    
>    Reviewed-by: ysr
>  - Fix confusing method name
>  - Revert "Test if we still (or ever) needed confusing is_old method"
>    
>    This reverts commit 5fcaef551d3286bd3e5eae485ac11c5b15ce7ed8.
>  - Test if we still (or ever) needed confusing is_old method

I don't think the test failures are related to this change, or the change you're working on. It looks like it has something to do with weak references:

java.lang.RuntimeException: expected testPhantom1 to be cleared
	at gc.shenandoah.TestReferenceRefersToShenandoah.fail(TestReferenceRefersToShenandoah.java:155)
	at gc.shenandoah.TestReferenceRefersToShenandoah.expectCleared(TestReferenceRefersToShenandoah.java:166)

Unfortunately, there is a failure in the reporting script that obscures this. I'll try to reproduce this failure separately.

-------------

PR Comment: https://git.openjdk.org/shenandoah/pull/517#issuecomment-2423387308