RFR: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option [v2]

SendaoYan syan at openjdk.org
Mon Oct 21 16:48:17 UTC 2024


On Mon, 21 Oct 2024 15:59:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   only unlock Stress* VM option
>
> test/hotspot/jtreg/gc/shenandoah/compiler/TestLoadBypassesNullCheck.java line 33:
> 
>> 31:  * @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:-TieredCompilation -XX:-UseOnStackReplacement -XX:-BackgroundCompilation
>> 32:  *                   -XX:+StressGCM -XX:+StressLCM -XX:+UseShenandoahGC -XX:LoopMaxUnroll=0 -XX:StressSeed=270847015
>> 33:  *                   TestLoadBypassesNullCheck
> 
> I am good with this fix, but if you have time to re-test it, consider reshuffling the arguments a bit, so that we only unlock what we need:
> 
> 
>  * @run main/othervm -XX:-TieredCompilation -XX:-UseOnStackReplacement -XX:-BackgroundCompilation 
>  *                   -XX:+UseShenandoahGC -XX:LoopMaxUnroll=0
>  *                   -XX:+UnlockDiagnosticVMOptions -XX:+StressGCM -XX:+StressLCM -XX:StressSeed=270847015
>  *                   TestLoadBypassesNullCheck

Thanks for your correction, arguments has been argument reshuffled.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21609#discussion_r1809156369


More information about the shenandoah-dev mailing list