RFR: 8342580: GenShen: TestChurnNotifications fails executing in unintended test-id modes with ShenandoahGCMode=generational

[Kelvin Nilsen]

On Fri, 18 Oct 2024 21:33:10 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

> Generational mode should not be tested with explicit heuristics settings, which are silently ignored. The test failed in these settings because it needs to be told which memory pool to check for notifications, which needs to be specified differently for generational. Ideally, we'd have the test figure this out rather than needing this to be explicitly specified. For now I just tightened the `@requires` clause to run only in the intended modes.
> 
> Related cleanups will follow separately (such as emitting a warning when an incompatible heuristics option is specified, code which may have been lost in a previous refactor). See details in the ticket.
> 
> **Testing** : tested with no specific collector, with Shenandoah, withGenShen, and with other collectors with test explicitly specified. As intended, in the first and second case 6 test-ids are run, in the thirdd case 1 test-id is run, and in the remaining cases, 0 test-ids are run.

Marked as reviewed by kdnilsen (Committer).

-------------

PR Review: https://git.openjdk.org/shenandoah/pull/520#pullrequestreview-2386382512