RFR: 8341371: CDS cannot load archived heap objects with -XX:+UseSerialGC -XX:-UseCompressedOops [v2]

[Calvin Cheung]

On Wed, 23 Oct 2024 16:40:44 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> [JDK-8298614](https://bugs.openjdk.org/browse/JDK-8298614) enabled writing the archived heap region with SerialGC and ParallelGC, but archives written with XX:-UseCompressedOops can't be loaded at runtime. This patch enables heap loading for SerialGC and ParallelGC as well as EpsilonGC and Shenandoah since they were enabled in [JDK-8341913](https://bugs.openjdk.org/browse/JDK-8341913). Related tests were updated to check for the new conditions. Verified with tier 1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Ioi comments

I spotted couple of things in the test cases.

test/hotspot/jtreg/runtime/cds/appcds/TestEpsilonGCWithCDS.java line 41:

> 39: 
> 40: // Below is exactly the same as above, except:
> 41: // - requires vm.bits == "64"

I don't see this requirement in the new test.

test/hotspot/jtreg/runtime/cds/appcds/TestEpsilonGCWithCDS.java line 46:

> 44: /*
> 45:  * @test Loading CDS archived heap objects into EpsilonGC
> 46:  * @bug 8234679

Please update the bug id.

test/hotspot/jtreg/runtime/cds/appcds/TestParallelGCWithCDS.java line 41:

> 39: 
> 40: // Below is exactly the same as above, except:
> 41: // - requires vm.bits == "64"

I don't see this requirement in the new test.

test/hotspot/jtreg/runtime/cds/appcds/TestParallelGCWithCDS.java line 46:

> 44:  /*
> 45:  * @test Loading CDS archived heap objects into ParallelGC
> 46:  * @bug 8274788

Please update the bug id.

-------------

Changes requested by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21647#pullrequestreview-2389409982
PR Review Comment: https://git.openjdk.org/jdk/pull/21647#discussion_r1813166147
PR Review Comment: https://git.openjdk.org/jdk/pull/21647#discussion_r1813167449
PR Review Comment: https://git.openjdk.org/jdk/pull/21647#discussion_r1813169167
PR Review Comment: https://git.openjdk.org/jdk/pull/21647#discussion_r1813169654