RFR: 8341371: CDS cannot load archived heap objects with -XX:+UseSerialGC -XX:-UseCompressedOops [v4]

[Ioi Lam]

On Wed, 23 Oct 2024 15:42:26 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> src/hotspot/share/prims/whitebox.cpp line 2162:
>> 
>>> 2160: 
>>> 2161: WB_ENTRY(jboolean, WB_CanWriteJavaHeapArchive(JNIEnv* env))
>>> 2162:   return HeapShared::can_write() && ArchiveHeapLoader::can_use();
>> 
>> Do we still need the `&& ArchiveHeapLoader::can_use()` part?
>
> I left it in since it may be a valuable check in case there are further changes or additions to the GCs.

But the code does not do what its name suggests. If this is not required now, I think we should remove the can_load part so the code is not confusing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21647#discussion_r1813352439