RFR: 8339346: GenShen: Remove even more stale TODOs

[Y. Srinivas Ramakrishna]

On Fri, 30 Aug 2024 21:22:59 GMT, William Kemper <wkemper at openjdk.org> wrote:

> Some of these have been done, some of these will not be done, some have been moved into our ticketing system, some of them are done in this PR.

Left a couple of minor comments.

LGTM otherwise; thanks for the cleanup!

src/hotspot/share/gc/shenandoah/shenandoahMarkingContext.hpp line 73:

> 71: 
> 72:   inline bool allocated_after_mark_start(oop obj) const;
> 73:   inline bool allocated_after_mark_start(const HeapWord* addr) const;

Any reason to remove the arg const-ness? Seems to hold and gives you a sense of the methods not modifying the args. Do we gain anything from removing the arg-constness? (I do see the "TODO" comment, but I'd erro towards removing the TODO comment and leaving the arg const-ness in place.

src/hotspot/share/gc/shenandoah/shenandoahMarkingContext.inline.hpp line 1:

> 1: /*

See comment re arg-constness above in .hpp.

src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.hpp line 785:

> 783:   void mark_range_as_dirty(size_t card_index, size_t num_cards);
> 784:   void mark_card_as_clean(size_t card_index);
> 785:   void mark_range_as_clean(size_t card_index, size_t num_cards);

Are these being removed because the "card_index" arg versions are never used, only the "heapword*" arg versions?

-------------

Marked as reviewed by ysr (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/491#pullrequestreview-2278613461
PR Review Comment: https://git.openjdk.org/shenandoah/pull/491#discussion_r1742765318
PR Review Comment: https://git.openjdk.org/shenandoah/pull/491#discussion_r1742766344
PR Review Comment: https://git.openjdk.org/shenandoah/pull/491#discussion_r1742801892