RFR: 8339695: GenShen: Concurrent reset performance has regressed

Aleksey Shipilev shade at openjdk.org
Mon Sep 9 15:10:41 UTC 2024


On Fri, 6 Sep 2024 19:47:50 GMT, William Kemper <wkemper at openjdk.org> wrote:

> A misguided optimization inadvertently increased the time to perform the concurrent reset phase of the GC cycle. This "optimization" has been reverted and the time for the phase has returned to normal.

Looks fine, consider a simple nit.

src/hotspot/share/gc/shenandoah/shenandoahGeneration.cpp line 69:

> 67:  private:
> 68:     ShenandoahRegionIterator _regions;
> 69:     ShenandoahGeneration* _generation;

Seems mis-indented a bit.

-------------

Marked as reviewed by shade (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/495#pullrequestreview-2290209146
PR Review Comment: https://git.openjdk.org/shenandoah/pull/495#discussion_r1750443643


More information about the shenandoah-dev mailing list