RFR: 8339870: Remove yet more stale TODOs [v2]
William Kemper
wkemper at openjdk.org
Wed Sep 11 17:12:27 UTC 2024
On Tue, 10 Sep 2024 19:47:40 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 687:
>>
>>> 685: _generation->prepare_regions_and_collection_set(true /*concurrent*/);
>>> 686:
>>> 687: // Upon return from prepare_regions_and_collection_set(), certain parameters have been established to govern the
>>
>> For the block comment at lines 687-702 (right pane), would it make sense to move it to the spec of `prepare_...` and remove this block comment from here?
>
> In fact, these are already present in the documentation for the method, so we should just remove this and declutter the code here.
Removed the block of comments and improved the comment on promotion reserve in old generation.
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/496#discussion_r1755187516
More information about the shenandoah-dev
mailing list