RFR: 8339616: GenShen: Introduce new state to distinguish promote-in-place phase as distinct from concurrent evacuation [v3]

William Kemper wkemper at openjdk.org
Tue Sep 24 16:21:04 UTC 2024


On Tue, 24 Sep 2024 16:03:04 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Split verification for only promote-in-place into a separate method
>>  - Assert that collection set is empty when only promoting regions
>>  - Make the distinction between only in-place-promotions and evacuations more clear
>
> src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp line 1086:
> 
>> 1084: }
>> 1085: 
>> 1086: void ShenandoahVerifier::verify_before_region_promotions() {
> 
> I think the better name is `::verify_after_concmark_with_promotions`. It is still "after mark" check first and foremost.

Okay

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/503#discussion_r1773666007


More information about the shenandoah-dev mailing list