RFR: 8344883: Force clients to explicitly pass mem_tag value, even if it is mtNone [v7]

Stefan Karlsson stefank at openjdk.org
Wed Apr 2 07:39:23 UTC 2025


On Tue, 1 Apr 2025 20:53:06 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> This is a follow-up to #21843. Here we are focusing on removing the mem tag paremeter with default value of mtNone, to force everyone to provide mem tag, if known.
>> 
>> I tried to fill in tag, when I was pretty certain that I had the right type.
>> 
>> At least one more follow-up will be needed after this, to change the remaining mtNone to valid values.
>
> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove default value parameter if it's false from os::reserve_memory

You keep leaving comments that ExecMem is a parameter. That doesn't make sense. ExecMem is a constant.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24282#pullrequestreview-2734939840


More information about the shenandoah-dev mailing list