RFR: 8344883: Force clients to explicitly pass mem_tag value, even if it is mtNone [v7]

[Stefan Karlsson]

On Tue, 1 Apr 2025 20:53:06 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> This is a follow-up to #21843. Here we are focusing on removing the mem tag paremeter with default value of mtNone, to force everyone to provide mem tag, if known.
>> 
>> I tried to fill in tag, when I was pretty certain that I had the right type.
>> 
>> At least one more follow-up will be needed after this, to change the remaining mtNone to valid values.
>
> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove default value parameter if it's false from os::reserve_memory

So, there were two problems:
1) Is the one I explained above. The failure mode is the build fails on some platforms.
2) The assert you listed above. That one is caused by the test first reserving with mtTest and then committing with mtGC. I simply also changed mtGC to mtTest and then the test passes.

Given the earlier issues with incorporating my feedback I'll provide my updated feedback as a branch instead. This is the diff:
https://github.com/openjdk/jdk/compare/pr/24282...stefank:jdk:pull_24282_stefank_feedback

And this is the branch:
https://github.com/stefank/jdk/tree/pull_24282_stefank_feedback

The you can fetch my branch to your local machine by running the following command:

git fetch https://github.com/stefank/jdk pull_24282_stefank_feedback:pull_24282_stefank_feedback


And then you can test my branch if you want. When you are satisfied that it doesn't have any problems, then you can bring my changes over to your own review branch by calling the following command (while having your review branch as the active branch):

git merge --ff pull_24282_stefank_feedback


And then you can add more changes if there are more tweaks that needs to be done.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24282#issuecomment-2771851832