Integrated: 8354452: Shenandoah: Enforce range checks on parameters controlling heuristic sleep times
William Kemper
wkemper at openjdk.org
Fri Apr 11 21:28:32 UTC 2025
On Fri, 11 Apr 2025 20:41:00 GMT, William Kemper <wkemper at openjdk.org> wrote:
> Without enforcing limits on `ShenandoahControlIntervalMin` and `ShenandoahControlIntervalMax`, the user may supply values that cause assertions to fail.
>
> This assertion failure has been observed in Genshen's regulator thread:
>
> #0 0x000028e8062d021a in ShenandoahRegulatorThread::regulator_sleep (this=0x4ef9701893b0) at src/hotspot/share/gc/shenandoah/shenandoahRegulatorThread.cpp:125
> #1 0x000028e8062d0027 in ShenandoahRegulatorThread::regulate_young_and_old_cycles (this=0x4ef9701893b0) at src/hotspot/share/gc/shenandoah/shenandoahRegulatorThread.cpp:95
> #2 0x000028e8062cfd06 in ShenandoahRegulatorThread::run_service (this=0x4ef9701893b0) at src/hotspot/share/gc/shenandoah/shenandoahRegulatorThread.cpp:51
>
> But it could just as easily happen in other modes to the `ShenandoahControlThread` instance.
This pull request has now been integrated.
Changeset: e8bcedb0
Author: William Kemper <wkemper at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/e8bcedb09b0e5eeb77bf1dc3a87bb61d7a5e8404
Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
8354452: Shenandoah: Enforce range checks on parameters controlling heuristic sleep times
Reviewed-by: ysr
-------------
PR: https://git.openjdk.org/jdk/pull/24602
More information about the shenandoah-dev
mailing list