RFR: 8354309: Sort GC includes
Kim Barrett
kbarrett at openjdk.org
Fri Apr 18 01:18:57 UTC 2025
On Thu, 10 Apr 2025 16:26:42 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> We now have a tool to fix our include lines to better adhere to the HotSpot Style Guide. See test/hotspot/jtreg/sources/SortIncludes.java. I've run the tool against the GC code and propose the resulting changes. I did one manual change to move a section guarded with INCLUDE_JFR.
>
> Builds successfully with GHA. I will run this through tier1-2.
It seems there is disagreement over whether the jtreg include order test is
desirable. In the interest of not blocking what I think is an otherwise good
cleanup, I'm withdrawing my request for an update to the test.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24581#pullrequestreview-2777201796
More information about the shenandoah-dev
mailing list