RFR: 8354282: C2: more crashes in compiled code because of dependency on removed range check CastIIs [v4]

[Christian Hagedorn]

On Thu, 27 Nov 2025 12:29:10 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> src/hotspot/share/opto/castnode.hpp line 101:
>> 
>>> 99:       }
>>> 100:       return NonFloatingNonNarrowing;
>>> 101:     }
>> 
>> Just a side note: We seem to mix the terms "(non-)pinned" with "(non-)floating" freely. Should we stick to just one? But maybe it's justified to use both depending on the situation/code context.
>
> The patch as it is now adds some extra uses of "pinned" and "floating". What could make sense, I suppose, would be to try to use "floating"/"non floating" instead but there are so many uses of "pinned" in the code base already, and I don't see us getting rid of them, that I wonder if it would make a difference. So, I'm not too sure what to do.

Yes, that's true. I was also unsure about whether we should stick with one or just allow both interchangeably. I guess since there are so many uses, we can just move forward with what you have now and still come back to clean it up if necessary - we can always do that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24575#discussion_r2581285955