RFR: 8373056: Shenandoah: Remove unnecessary use of ShenandoahAllocRequest.type() [v2]
Xiaolong Peng
xpeng at openjdk.org
Wed Dec 3 23:30:21 UTC 2025
> Follow up on the feedback/comments on PR https://github.com/openjdk/jdk/pull/28521 for bug [JDK-8372566](https://bugs.openjdk.org/browse/JDK-8372566), we should avoid using ShenandoahAllocRequest.type() directly if possible, in most of cases we don't need to directly use alloc type, the inline member methods provided by ShenandoahAllocRequest should be sufficient.
>
> In the PR, I have removed most of the places where ShenandoahAllocRequest.type() directly used, there will be only one place left after the change:
> * ShenandoahFreeSet::allocate (This one will be removed with PR https://github.com/openjdk/jdk/pull/26171)
>
> Also did small code rearrangement for ShenandoahOldGeneration::configure_plab_for_current_thread
>
> ### Test
> - [x] hotspot_gc_shenandoah
> - [ ] GHA
Xiaolong Peng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- Merge branch 'openjdk:master' into JDK-8373056
- Remove direct use of alloc type from ShenandoahHeapRegion::adjust_alloc_metadata
- Revert log change
- Remove unnecessary use of ShenandoahAllocRequest.type()
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/28649/files
- new: https://git.openjdk.org/jdk/pull/28649/files/28f802d8..59087c8e
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=28649&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=28649&range=00-01
Stats: 9796 lines in 279 files changed: 6048 ins; 2286 del; 1462 mod
Patch: https://git.openjdk.org/jdk/pull/28649.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28649/head:pull/28649
PR: https://git.openjdk.org/jdk/pull/28649
More information about the shenandoah-dev
mailing list