RFR: 8373039: Remove Incorrect Asserts in shenandoahScanRemembered [v2]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Thu Dec 4 01:22:57 UTC 2025
On Wed, 3 Dec 2025 22:08:11 GMT, Ben Taylor <btaylor at openjdk.org> wrote:
>> The `Klass->is_valid` asserts in this file do not hold the required `ClassLoaderDataGraph_lock` and can cause a crash.
>>
>> A similar issue was seen in https://bugs.openjdk.org/browse/JDK-8372566
>>
>> This change passes all tests in `TEST=hotspot_gc_shenandoah` with a fastdebug build
>
> Ben Taylor has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix up comment and remove additional assert from previous commit
One more fix to the comment.
LGTM otherwise. Thanks for the cleanups.
src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.cpp line 372:
> 370: // and then too only during promotion/evacuation phases. Thus there is no danger
> 371: // of races between reading from and writing to the object start array,
> 372: // or of asking partially initialized objects their size (in the loop below).
Remove reference to "in the loop below".
-------------
Marked as reviewed by ysr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28642#pullrequestreview-3537496302
PR Review Comment: https://git.openjdk.org/jdk/pull/28642#discussion_r2587092135
More information about the shenandoah-dev
mailing list