RFR: 8373056: Shenandoah: Remove unnecessary use of ShenandoahAllocRequest.type() [v2]

[Xiaolong Peng]

On Thu, 4 Dec 2025 00:36:56 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Xiaolong Peng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8373056
>>  - Remove direct use of alloc type from ShenandoahHeapRegion::adjust_alloc_metadata
>>  - Revert log change
>>  - Remove unnecessary use of ShenandoahAllocRequest.type()
>
> src/hotspot/share/gc/shenandoah/shenandoahOldGeneration.cpp line 198:
> 
>> 196: void
>> 197: ShenandoahOldGeneration::configure_plab_for_current_thread(const ShenandoahAllocRequest &req) {
>> 198:   // Note: Even when a mutator is performing a promotion outside a LAB, we use a 'shared_gc' request.
> 
> Is this comment vestigial now? This method doesn't handle shared allocations anymore.

Yeah, it is outdated, I will remove it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28649#discussion_r2587092735