RFR: 8373056: Shenandoah: Remove unnecessary use of ShenandoahAllocRequest.type() [v3]

Xiaolong Peng xpeng at openjdk.org
Thu Dec 4 23:59:14 UTC 2025


On Thu, 4 Dec 2025 01:23:55 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:

>> Follow up on the feedback/comments on PR https://github.com/openjdk/jdk/pull/28521 for bug [JDK-8372566](https://bugs.openjdk.org/browse/JDK-8372566), we should avoid using ShenandoahAllocRequest.type() directly if possible, in most of cases we don't need to directly use alloc type, the inline member methods provided by ShenandoahAllocRequest should be sufficient.
>> 
>> In the PR, I have removed most of the places where ShenandoahAllocRequest.type() directly used, there will be only one place left after the change:
>> * ShenandoahFreeSet::allocate (This one will be removed with PR https://github.com/openjdk/jdk/pull/26171)
>> 
>> Also did small code rearrangement for ShenandoahOldGeneration::configure_plab_for_current_thread 
>> 
>> ### Test
>> - [x] hotspot_gc_shenandoah
>> - [x] GHA
>
> Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove outdated comments

Thanks all for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28649#issuecomment-3614774632


More information about the shenandoah-dev mailing list