RFR: 8373801: Adopt arraycopy OopCopyResult from the lworld branch [v2]

Joel Sikström jsikstro at openjdk.org
Fri Dec 19 09:07:46 UTC 2025


On Tue, 16 Dec 2025 15:04:44 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> In the Valhalla project there's code to restrict nulls in object arrays. In the GC arraycopy barrier we there have to both do null checks in addition to the already existing cast checks. If one of these two failed the code needs to propagate this up through the callers to the code that asked to do the checks. There it will throw the suitable exception. Previously, it was enough to say success or failed, and a boolean was enough. Now we need three states. So the bool was replaced with an OopCopyResult enum.
>> 
>> See: https://github.com/openjdk/valhalla/pull/1792
>> 
>> I propose that we bring this over to the mainline to lower the diff between lworld and the openjdk/jdk.
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove throw NPE function

Looks good.

-------------

Marked as reviewed by jsikstro (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28850#pullrequestreview-3597654894


More information about the shenandoah-dev mailing list