RFR: 8374145: Remove legacy locking remnants from markWord
Kim Barrett
kbarrett at openjdk.org
Fri Dec 19 18:08:28 UTC 2025
On Fri, 19 Dec 2025 14:05:13 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> There's a bunch of unused code in markWord that used to be used by the removed legacy locking. I propose that we remove it.
>
> There's a Shenandoah change that should be checked closer. My thinking is:
> `is_being_inflated`: always returns false
> `has_displaced_mark_helper`: Only returns true if both these are true:
> * `!UseCompactObjectTable` - there's an early return for this earlier in the function.
> * `lockbits == monitor_value` - checked in the if-statement above
Looks good. No opinion about @xmas92 suggestion in the shenandoah change.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28927#pullrequestreview-3599550836
More information about the shenandoah-dev
mailing list