RFR: 8349094: GenShen: Race between control and regulator threads may violate assertions [v12]

[William Kemper]

On Sat, 15 Feb 2025 01:41:48 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahGenerationalControlThread.cpp line 98:
>> 
>>> 96:   }
>>> 97: 
>>> 98:   // In case any threads are waiting for a cycle to happen, let them know it isn't.
>> 
>> maybe "it isn't happening", or "it won't happen".
>
> This is interesting. If GC is stopping prior to shutting down the VM, is there any point in notifying these waiting threads. Why not let them wait, and quietly shut things down? Are there JCK or other tests that would fail in that case?

The waiting threads will remain waiting and prevent the JVM from shutting down.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23475#discussion_r1968113830