RFR: 8350314: Shenandoah: Capture thread state sync times in GC timings [v2]

Xiaolong Peng xpeng at openjdk.org
Tue Feb 25 23:27:22 UTC 2025


On Tue, 25 Feb 2025 23:00:28 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 694:
> 
>> 692:   {
>> 693:     ShenandoahGCPhase phase(ShenandoahPhaseTimings::init_propagate_gc_state);
>> 694:     ShenandoahHeap::heap()->propagate_gc_state_to_all_threads();
> 
> A nit, but can we use the `heap` variable that is already in scope for these `propagate_gc_state_to_all_threads` calls?

Thanks, I have updated the PR to use `heap` variable in scope.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23759#discussion_r1970679549


More information about the shenandoah-dev mailing list